Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to address incorrect package versions in DataProtection Configuration document (Issue #19770) #19771

Merged
merged 8 commits into from
Sep 4, 2020

Conversation

markmcgookin
Copy link
Contributor

Fixes #19770

Update to fix package references and minor configuration changes when moving to the new libraries.

Left the workaround in place for the issue with the old library incase people are googling the error and come across the document (included a comment suggesting them to upgrade)

@guardrex
Copy link
Collaborator

guardrex commented Sep 3, 2020

@Rick-Anderson ... This isn't the only spot for the updates. I don't see any sample apps that need work, but there are perhaps four more topics that need updates.

@Rick-Anderson
Copy link
Contributor

@pakrym please review or recommend a reviewer

@markmcgookin
Copy link
Contributor Author

I've updated the PR at @pakrym 's request to have the original setup arguments, I changed mine when migrating to the new libraries, but apparently the original ones in the documentation still work.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markmcgookin! 🚀

@guardrex guardrex merged commit 9663427 into dotnet:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataProtection Configuration references the wrong libraries
4 participants