New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on MaximumReceiveMessageSize #27014
Conversation
Let's hold off on review. We're discussing this on the PU issue. We might do something different ... an INCLUDE used in the Blazor doc and the SignalR doc, for example. We might do this, but we might only do it in the SignalR doc because the Blazor doc already links to the SignalR doc for the configuration details. |
The PU issue was closed right in the middle of the discussion on this. Let's go with Rick's Gambit™ ... i.e. ... Call for review! 😆 Brennan, which way would you like to go?
|
Sure, similar to how |
@BrennanConroy ... Added a remark to the table. How's it look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will leave the final sign-off for @BrennanConroy
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd await @BrennanConroy's signoff.
I will ... and btw ... I've talked myself out of using the explicit byte conventions for abbreviations, as you recommended, on the issue that I opened ... I wish MS/.NET foundation would adopt the standard. What I can do is place a remark on it in the Blazor Fundamentals topic and just use "KB"/"MB"/"GB" everywhere.
|
@BrennanConroy ... Are you OOF? No rush ... just checking. |
@BrennanConroy ... Ok ... ready for another 👁️. |
Fixes #27013