UseHealthChecks vs. MapHealthChecks /5 #29439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JuergenGutsch please review. It's way too long, should I cut most of that out? |
|
@ngbrown please review |
cremor
reviewed
Jun 7, 2023
cremor
reviewed
Jun 7, 2023
|
@CarlosLanderas @jods4 @mettelephant @FirstAfterGod2501 @bhugot please review |
|
@Rick-Anderson I think the updated explanation looks good. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@JuergenGutsch please review. It's way too long, should I cut most of that out? |
|
I seems like in .NET 8 we will be able to write |
This comment was marked as resolved.
This comment was marked as resolved.
JamesNK
reviewed
Jul 6, 2023
Comment on lines
311
to
313
| * Provides a default health check without specifying a path. Allows performing a health check on the root path or any request made to the specified port. | ||
| * Selecting any endpoint on a port. | ||
| * Provides a catch-all health check. Handles health checks for any path. |
There was a problem hiding this comment.
These are all saying the same thing.
There was a problem hiding this comment.
These are all saying the same thing.
@JamesNK Can you make a suggestion of the lines to delete?
Co-authored-by: James Newton-King <james@newtonking.com>
JamesNK
reviewed
Jul 7, 2023
Co-authored-by: James Newton-King <james@newtonking.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29421
Internal previews