Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthscore udpates: Web API help pages with Swagger and Start NSwag #32395

Closed
wants to merge 4 commits into from

Conversation

wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Apr 25, 2024

Healthscore related updates.
Contributes to #32305

Minor updates to the app sample to version 8 with updates for the following packages:

  • Microsoft.EntityFrameworkCore.InMemory Version="8.0.4"
  • NSwag.AspNetCore Version="14.0.7"

Also targeted the project for .NET 8 and tested it.

Minor update to: tutorials/getting-started-with-NSwag.md

  • Updated ms.date
  • Moved to version by include file
  • Updated code links to the new version 8 sample.

Minor update to: tutorials/web-api-help-pages-using-swagger.md

  • Updated ms.date

Internal previews

馃搫 File 馃敆 Preview link
aspnetcore/tutorials/getting-started-with-NSwag.md Get started with NSwag and ASP.NET Core
aspnetcore/tutorials/web-api-help-pages-using-swagger.md ASP.NET Core web API documentation with Swagger / OpenAPI

@wadepickett wadepickett self-assigned this Apr 25, 2024
@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Apr 25, 2024

@wadepickett we shouldn't be making changes to v8 doc's using Swagger. We should be working on dotnet/aspnetcore#54599

@wadepickett
Copy link
Contributor Author

wadepickett commented Apr 25, 2024

I see what you mean. Mark had asked me to hit some topics to improve the health score for this sprint such as refresh dates, so I was going down a list of topics that were relatively high traffic but had not had a refresh and ran into this one which was showing 2019. The sample, however, needed to be updated to 8.0 even though it already was using NSwag in a development environment only, which we were using as part of the swagger solution. So I was just updating both topics and the sample since it wasn't a big time commitment in between working on others. I already pretty much have this done, OK to finish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants