-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Min Web API: Corrected Put data in body #32498
Conversation
The issue mentions the status code being wrong, doesn't say anything about the id field. Does the link point to the right issue? |
The ID issue is detailed in the discussion portion of that issue. "The other item on that page that should be updated is in the Test the PUT endpoint section. The example provides the ID in the body of the request but it is not used by the logic: Content-Type: application/json { The "id": 1, line should be removed. The ID is pulled from the URI, not the body of the request." |
Sorry, that is odd, I just edited your text rather than creating new text. Fixed it. See my note about the ID problem brought up in the discussion, not the description. It is the right associated issue. I will change the Issue title so it is not confusing. |
While we technically can pass the ID in the body at the same time as specifying the ID in the URL, it would not be best practice to do both. It adds a bit of risk to the two pieces of data being out of sync. |
Thanks for the clarification. Was the part about 200 vs. 204 incorrect, so nothing needed to be done? |
Correct. I verified following the instruction steps and could not recreate the 200 vs. 204 problem, and in the discussion I provided a screen shots of the results. Another community member also did the same. |
Sorry for the confusion, I should have also updated the original issue description to make it clear there were two issues brought up, but one was a non-issue, not reproducible. Thanks. |
Fixes #32239
Minor change.
Two items were mentioned in the issue, only one turned out to need a fix which was to remove the id from the PUT data in the body. This fix was not needed for previous versions, just the current v 8.0.
Internal previews