Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor Server reconnection coverage #32790

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jun 10, 2024

Fixes #32789
Addresses #32692
Addresses #31909

Mackinnon, I'm blocked at the moment on working on the What's New side of this until another PR merges, but I'll have the What's New part for this updated (some coverage was placed that I'll be touching up) by EOD on a separate PR.

UPDATE: Not blocked any longer on What's New. I'll take care of it after the four reference article PRs are merged.

WRT this coverage: It seems like we'd call the default logic "a computed backoff strategy" instead of "an exponential backoff strategy." However, your custom example is exponential, so I retain that language for the example.

I was curious about the default logic, and I think devs will be curious, too. The link goes here ...

https://github.com/search?q=repo%3Adotnet%2Faspnetcore%20computeDefaultRetryInterval&type=code

... and that's probably a decent approach for avoiding a hard link with a specific set of line numbers. It will work well as long as the FN name computeDefaultRetryInterval is stable. I like the way that it finds the exact line in the file for them when they click on the search result, and I like the way that it would find this FN if it moved to a different file in the future. However, we can pull that link and those remarks if you don't want to risk it breaking at some point.

As usual, the INCLUDE that explains what the link loads follows the link, and the content of that INCLUDE can be seen here ...

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/includes/aspnetcore-repo-ref-source-links.md


Internal previews

馃搫 File 馃敆 Preview link
aspnetcore/blazor/fundamentals/signalr.md ASP.NET Core Blazor SignalR guidance

@MackinnonBuck
Copy link
Member

It will work well as long as the FN name computeDefaultRetryInterval is stable

Yeah, I think that's probably fine. In the worst case, we accidentally rename it in the future, but we then will likely get reports of a broken link and fix it.

guardrex and others added 3 commits June 10, 2024 19:45
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
@guardrex
Copy link
Collaborator Author

Try it now, but I'm not sure if that wording is exactly right ... I've been working here from 6am to 8pm non-stop 馃槱.

aspnetcore/blazor/fundamentals/signalr.md Outdated Show resolved Hide resolved
aspnetcore/blazor/fundamentals/signalr.md Outdated Show resolved Hide resolved
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
@guardrex
Copy link
Collaborator Author

Ok ... all good.

馃嵒

I'll get this merged as soon as it builds.

@guardrex guardrex merged commit 44c7d44 into main Jun 11, 2024
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-preview-5-coverage branch June 11, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor Server reconnection (9.0 Preview 5)
2 participants