Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subdomain config in cookie sharing topic #7791

Merged
merged 4 commits into from Jul 24, 2018
Merged

Conversation

guardrex
Copy link
Collaborator

Fixes #7392

@guardrex guardrex requested a review from scottaddie July 24, 2018 18:07
@guardrex
Copy link
Collaborator Author

@scottaddie Since Chris is OOF this week, I think we can go by his remark on the issue as to the sufficiency of these updates. 👉 #7392 (comment)

```csharp
options.Cookie.Domain = ".contoso.com";
```

See the *CookieAuthWithIdentity.Core* project in the [sample code](https://github.com/aspnet/Docs/tree/master/aspnetcore/security/cookie-sharing/sample/) ([how to download](xref:tutorials/index#how-to-download-a-sample)).

# [ASP.NET Core 1.x](#tab/aspnetcore1x/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the tabs while you're in here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting dogged a little bit over 2.1 issues atm. I recommend an issue for this work pushed back a few sprints, which should provide enough time to catch up on a bunch of 2.1 sample updates. Do u agree?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with that approach.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan is to make another big dent in 2.1 sample updates this sprint. I have the mega-Configuration issue to work on this sprint. Other than that tho, it looks like I'll have time for some good 2.1 sample update work.

@guardrex guardrex merged commit 109b1c4 into master Jul 24, 2018
@guardrex guardrex deleted the guardrex-patch-4 branch July 24, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants