ensure access to logger is synchronized for async output reader (#2133)

fixes #2125
dotnet · Oct 5, 2022 · 97c2d14 · 97c2d14
1 parent f4d99ab
commit 97c2d14
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/BenchmarkDotNet/Loggers/AsyncProcessOutputReader.cs b/src/BenchmarkDotNet/Loggers/AsyncProcessOutputReader.cs
@@ -106,8 +106,14 @@ private void ProcessOnOutputDataReceived(object sender, DataReceivedEventArgs e)
             if (!string.IsNullOrEmpty(e.Data))
             {
                 output.Enqueue(e.Data);
+
                 if (logOutput)
-                    logger.WriteLine(e.Data);
+                {
+                    lock (this) // #2125
+                    {
+                        logger.WriteLine(e.Data);
+                    }
+                }
             }
         }
 
@@ -116,8 +122,14 @@ private void ProcessOnErrorDataReceived(object sender, DataReceivedEventArgs e)
             if (!string.IsNullOrEmpty(e.Data))
             {
                 error.Enqueue(e.Data);
+
                 if (logOutput)
-                    logger.WriteLineError(e.Data);
+                {
+                    lock (this) // #2125
+                    {
+                        logger.WriteLineError(e.Data);
+                    }
+                }
             }
         }