Added pointers to SampleBenchmark test, and fixed the test failure.

Added comment about `Type.IsClass` returns true for pointers.
dotnet · May 17, 2023 · fbdb74c · fbdb74c
1 parent 7abb119
commit fbdb74c
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 0 deletions.
diff --git a/src/BenchmarkDotNet/Engines/Consumer.cs b/src/BenchmarkDotNet/Engines/Consumer.cs
@@ -131,6 +131,7 @@ public void Consume<T>(in T value)
             => byteHolder = Unsafe.As<T, byte>(ref Unsafe.AsRef(in value));
 
         internal static bool IsConsumable(Type type)
+            // IsClass returns true for pointers.
             => SupportedTypes.Contains(type) || type.GetTypeInfo().IsClass || type.GetTypeInfo().IsInterface || !type.IsByRefLike();
 
         internal static bool HasConsumableField(Type type, out FieldInfo consumableField)

diff --git a/src/BenchmarkDotNet/Helpers/Reflection.Emit/IlGeneratorDefaultValueExtensions.cs b/src/BenchmarkDotNet/Helpers/Reflection.Emit/IlGeneratorDefaultValueExtensions.cs
@@ -39,6 +39,14 @@ public static void EmitReturnDefault(this ILGenerator ilBuilder, Type resultType
             {
                 case Type t when t == typeof(void):
                     break;
+                case Type t when t.IsPointer: // Type.IsClass returns true for pointers, so we have to check for pointer type first.
+                    /*
+                        IL_0000: ldc.i4.0
+                        IL_0001: conv.u
+                     */
+                    ilBuilder.Emit(OpCodes.Ldc_I4_0);
+                    ilBuilder.Emit(OpCodes.Conv_U);
+                    break;
                 case Type t when t.IsClass || t.IsInterface:
                     ilBuilder.Emit(OpCodes.Ldnull);
                     break;

diff --git a/tests/BenchmarkDotNet.IntegrationTests/InProcess.EmitTests/SampleBenchmark.cs b/tests/BenchmarkDotNet.IntegrationTests/InProcess.EmitTests/SampleBenchmark.cs
@@ -43,6 +43,27 @@ public EmptyStruct ReturnManyArgsCase(ref double i, int j, string k, object l)
             return ref refValueHolder;
         }
 
+        [Benchmark]
+        public unsafe int* ReturnsIntPointer()
+        {
+            Thread.Sleep(100);
+            return default;
+        }
+
+        [Benchmark]
+        public unsafe void* ReturnsVoidPointer()
+        {
+            Thread.Sleep(100);
+            return default;
+        }
+
+        [Benchmark]
+        public unsafe EmptyStruct* ReturnsStructPointer()
+        {
+            Thread.Sleep(100);
+            return default;
+        }
+
         [Benchmark, Arguments(12)]
         public Task<int> TaskSample(long arg)
         {