Escape the build arguments containing backslash #1593
Conversation
|
|
ghost
closed this
ghost
deleted the
ghost
reopened this
ghost
mentioned this pull request
src/BenchmarkDotNet/Jobs/Argument.cs
Outdated
| /// <param name="args"></param> | ||
| /// <returns></returns> |
There was a problem hiding this comment.
nit: we try to avoid empty descriptions, so this can be just removed
| /// <param name="args"></param> | |
| /// <returns></returns> |
There was a problem hiding this comment.
Removed the description from the documentation section
src/BenchmarkDotNet/Jobs/Argument.cs
Outdated
| /// </summary> | ||
| /// <param name="args"></param> | ||
| /// <returns></returns> | ||
| public string EscapeBuildArguments(string args) |
There was a problem hiding this comment.
could you please make this method internal and add some simple unit test for it?
There was a problem hiding this comment.
Marked the method as internal instead of public
| /// <returns></returns> | ||
| public string EscapeBuildArguments(string args) | ||
| { | ||
| if (args.Contains("\\")) |
There was a problem hiding this comment.
we should also consider the case where the user provides an already escaped characters like new MsBuildArgument("/p:a=b\\\\") and to be 100% complete a version when there is a mix like ("/p:\a=b\\\\")`
There was a problem hiding this comment.
Added unit test cases to cover the scenarios as suggested
Added unit test cases for escaping MSBuildArguments
|
@adamsitnik |
|
@adamsitnik could you please review the PR? |
ghost
closed this
Fixes the following issue with passing build arguments
System.FormatException in AfterAssemblyLoadingAttached