BenchmarkSwitcher should support generic types with parameterless public ctors

[adamsitnik]

It's possible to run generic benchmarks via BenchmarkRunner.Run<T> but not via BenchmarkSwitcher.FromTypes

Case: I am currently benchmarking the serializers. I don't want to create new class per type.

BenchmarkSwitcher.FromTypes
    (
        new[]
        {
            typeof(Json_SerializeToString<LoginViewModel>),
            typeof(Json_SerializeToString<Location>),

            typeof(Json_SerializeToStream<LoginViewModel>),
            typeof(Json_SerializeToStream<Location>),
        }
    )
    .Run(args, new BenchmarkConfig());

public class Json_SerializeToString<T>
{
    private readonly T value;

    public Json_SerializeToString() => value = DataGenerator.Generate<T>();

    [Benchmark(Description = "Jil")]
    public string Jil_() => Jil.JSON.Serialize<T>(value);

    [Benchmark(Description = "JSON.NET")]
    public string JsonNet_() => Newtonsoft.Json.JsonConvert.SerializeObject(value);

    [Benchmark(Description = "Utf8Json")]
    public string Utf8Json_() => Utf8Json.JsonSerializer.ToJsonString(value);
}

@AndreyAkinshin to prevent some bugs I am going to add a requirement: generics are ok if the type has a public parameterless ctor.

[AndreyAkinshin]

to prevent some bugs I am going to add a requirement: generics are ok if the type has a public parameterless ctor.

LGTM

[adamsitnik]

Done! @nietras @xoofx guys you might be interested in updating to 0.10.12.443 since it has better generics support (full names are used everywhere, not Generic`1 thing)

static void Main(string[] args)
    => BenchmarkSwitcher.FromTypes
        (
            new[]
            {
                typeof(Json_ToString<LoginViewModel>),
                typeof(Json_ToString<Location>),
                typeof(Json_ToString<IndexViewModel>),

                typeof(Json_ToStream<LoginViewModel>),
                typeof(Json_ToStream<Location>),
                typeof(Json_ToStream<IndexViewModel>),

                typeof(Json_FromString<LoginViewModel>),
                typeof(Json_FromString<Location>),
                typeof(Json_FromString<IndexViewModel>),

                typeof(Json_FromStream<LoginViewModel>),
                typeof(Json_FromStream<Location>),
                typeof(Json_FromStream<IndexViewModel>),
            }
        )
        .Run(args, new BenchmarkConfig());

[nietras]

Nice!

…

On Feb 19, 2018 17:03, "Adam Sitnik" ***@***.***> wrote: Done! @nietras <https://github.com/nietras> @xoofx <https://github.com/xoofx> guys you might be interested in updating to 0.10.12.443 since it has better generics support (full names are used everywhere, not Generic`1 thing) static void Main(string[] args) => BenchmarkSwitcher.FromTypes ( new[] { typeof(Json_ToString<LoginViewModel>), typeof(Json_ToString<Location>), typeof(Json_ToString<IndexViewModel>), typeof(Json_ToStream<LoginViewModel>), typeof(Json_ToStream<Location>), typeof(Json_ToStream<IndexViewModel>), typeof(Json_FromString<LoginViewModel>), typeof(Json_FromString<Location>), typeof(Json_FromString<IndexViewModel>), typeof(Json_FromStream<LoginViewModel>), typeof(Json_FromStream<Location>), typeof(Json_FromStream<IndexViewModel>), } ) .Run(args, new BenchmarkConfig()); [image: image] <https://user-images.githubusercontent.com/6011991/36386540-5a40e7e2-1596-11e8-8238-5494eeef0bd0.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#652 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKTG79LMqoruzkTUfQHiKY5ArA9OSDFrks5tWZtLgaJpZM4SJAxp> .

[xoofx]

Amazing, thanks @adamsitnik!