New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added information about what a Gen X column means #1175
Conversation
Added information about what a Gen X means. Right now the definition is ambiguous of whether it is the number of objects in that generation or the number of collections in that generation
Hey @jigargandhi! Thanks for the PR.
|
Hey @jigargandhi! Would you like to update your PR? |
Hey,
yes I will update it in a day or two
…On Sat, 13 Jul 2019, 20:54 Andrey Akinshin, ***@***.***> wrote:
Hey @jigargandhi <https://github.com/jigargandhi>! Would you like to
update your PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1175?email_source=notifications&email_token=AAC46MMY3DELMYEBO74PWW3P7HXTPA5CNFSM4HSFBOU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ3TVIQ#issuecomment-511130274>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC46MPNUEUZBDU4IKYZO5DP7HXTPANCNFSM4HSFBOUQ>
.
|
Removed the text "to clean up memory" as GC generation may not clean up memory
@jigargandhi the new version is still not correct. This column displays the number of collections per 1000 operations. |
Missed adding per 1000 operations
Also, the current sentence doesn't have a mention of GC (the corresponding line in the legend has this information: "GC Generation {generationId} collects per 1000 operations"); a period at the end of the sentence is missing. |
Added GC collections to the statement
@jigargandhi thanks! |
Added information about what a Gen X means. Right now the definition is ambiguous of whether it is the number of objects in that generation or the number of collections in that generation