Add EnumParam preserving type information #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to write proper tests for this case, but it doesn't clear how to run F# integration "test suite". Could you help me please? @adamsitnik @AndreyAkinshin Thanks! |
|
@isaevdan Review please! |
gsomix
changed the title
gsomix
force-pushed
the
feature/1262-fsharp-enums
branch
from
b9b7195
to
ea959b3
Compare
gsomix
force-pushed
the
feature/1262-fsharp-enums
branch
from
ea959b3
to
718b776
Compare
|
Ready to review. :) |
|
I see this is still open. In case if it is waiting for me, I`m still fine with implementation :) |
|
@adamsitnik @AndreyAkinshin Hey, guys, any chance to get it merged? Thanks! |
AndreyAkinshin
approved these changes
Dec 12, 2019
|
@gsomix thanks for the PR and sorry for the delay. |
|
@AndreyAkinshin @gsomix |
|
@isaevdan yes, the fix will be available in 0.12.1. The new version should be released this week. |
|
@AndreyAkinshin Great, thanks for update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1262
I've added new type for enum params, that preserves type information for erasured F# enums in attributes. There is obvious code duplication, but that's for reason to keep code changes small and local. We can remove it after F# compiler is fixed. ;)
See also:
dotnet/fsharp#995
Happy #hacktoberfest!