Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Utf8 not just for writing to standard output, but also for reading from standard input #1735

Merged
merged 1 commit into from Jul 5, 2021
Merged

Use Utf8 not just for writing to standard output, but also for reading from standard input #1735

merged 1 commit into from Jul 5, 2021

Conversation

adamsitnik
Copy link
Member

fixes #1713

Repro:

git clone https://github.com/dotnet/BenchmarkDotNet.git bdn
cd bdn\samples\BenchmarkDotNet.Samples
chcp 65001
dotnet run -c Release -f net461 --filter BenchmarkDotNet.Samples.IntroColdStart.Foo --runtimes net461 net50

cc @stephentoub

@adamsitnik adamsitnik added this to the v0.13.1 milestone Jun 29, 2021
@stephentoub
Copy link
Member

Thanks for the quick turnaround.

@adamsitnik adamsitnik mentioned this pull request Jun 29, 2021
Closed
@adamsitnik adamsitnik merged commit e7ff4ce into master Jul 5, 2021
@adamsitnik adamsitnik deleted the codePageFix branch July 5, 2021 10:40
@adamsitnik adamsitnik mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

Assignees
No one assigned
Labels
Area:Toolchains
Projects
None yet
Milestone
v0.13.1
Development

Successfully merging this pull request may close these issues.

System.NotSupportedException: Unknown Acknowledgment: Acknowledgment when running in a github action
3 participants
@adamsitnik @stephentoub @AndreyAkinshin