Fix pointer-returning benchmarks support for InProcessToolchain #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcassell
reviewed
Jul 27, 2021
tests/BenchmarkDotNet.IntegrationTests/ValuesReturnedByBenchmarkTest.cs
Outdated
Show resolved
Hide resolved
Merged
|
Closing in favour of #1747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I've merged #1739 one
MemoryDiagnosertest started failing forInProcessToolchainI initially thought it's something related toTieredJitand ignored it (my bad).It turned out that
InProcessToolchainrequired a fix to make it work with #1739I've added tests for both
void*andT*and ensured they now work for every toolchain (.NET, Core and InProcess).This should make the CI green again cc @radekdoulik @kant2002