1799 adding resume arg #2164
1799 adding resume arg #2164
Conversation
|
|
There was a problem hiding this comment.
@melias thank you for your contribution! PTAL at my comments.
melias
requested review from
adamsitnik and
timcassell
and removed request for
adamsitnik and
timcassell
| foreach (var benchmarkRunInfo in supportedBenchmarks) // we run them in the old order now using the new build artifacts | ||
| { | ||
| if (benchmarkRunInfo.Config.Options.IsSet(ConfigOptions.Resume)) |
There was a problem hiding this comment.
nit: we can assume that if parsedIdToResume was parsed (at least one of the configs defined it), we are using it as source of truth
| if (benchmarkRunInfo.Config.Options.IsSet(ConfigOptions.Resume)) | |
| if (parsedIdToResume > 0) |
tests/BenchmarkDotNet.IntegrationTests/BenchmarkSwitcherTest.cs
Outdated
Show resolved
Hide resolved
…ce of truth. Includes the skipped benchmarks too.
…st regarding --resume
There was a problem hiding this comment.
During manual testing I've found some edge case bugs, but since we don't have much time (the hackathon ends today) I've sent some minor polishing fixes directly to your fork.
Thank you for your contribution @melias !
Thanks @adamsitnik |
|
Is this repository participating in hacktoberfest?
Look at dotnet/runtime#76515. It looks like you need to add a label to the repository: |
…as not been created yet
We are currently participating in https://code.devexperts.com/event/openhack22
I don't have permissions to do that, @AndreyAkinshin could you please add the label? @YegorStepanov in the past we had to apply Hacktoberfest labels to issues/PRs in order for the contributions to count. Please let me know if I should add these labels to any of your PRs |
Done. |
You can remove |
No description provided.