AggressiveOptimization in InProcess toolchains
#2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/BenchmarkDotNet/Toolchains/InProcess/NoEmit/BenchmarkActionFactory_Implementations.cs
Outdated
Show resolved
Hide resolved
src/BenchmarkDotNet/Helpers/Reflection.Emit/MethodBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
AndreyAkinshin
approved these changes
Jul 20, 2023
adamsitnik
reviewed
Jul 20, 2023
| public static class CodeGenHelper | ||
| { | ||
| // AggressiveOptimization is not available in netstandard2.0, so just use the value casted to enum. | ||
| public const MethodImplOptions AggressiveOptimizationOption = (MethodImplOptions) 512; |
There was a problem hiding this comment.
is this value ignored by the older runtimes?
cc @AndyAyersMS who added the annotations with ifdefs
There was a problem hiding this comment.
Yes, I believe it will be ignored by older .NET Core and all .NET Framework versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1935, fixes #1934 for in-process toolchains.