Use out-of-process disassembler with InProcessEmitToolchain #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcassell
force-pushed
the
inprocess-disassemble
branch
6 times, most recently
from
1d00b95
to
d11e60f
Compare
timcassell
force-pushed
the
inprocess-disassemble
branch
from
d11e60f
to
29e4141
Compare
timcassell
changed the title
timcassell
changed the title
timcassell
force-pushed
the
inprocess-disassemble
branch
from
29e4141
to
5f4298c
Compare
timcassell
force-pushed
the
inprocess-disassemble
branch
from
5f4298c
to
82ac1d6
Compare
|
Thanks @danmoseley. Of course I would like to fix it properly, but it looks like that release is still blocking for us. Discussion about it in #2383. |
|
Superseded by #2488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2383
This is kind of a hacky workaround to make it work on Windows x64/x86. When ClrMd fixes it on their end (dotnet/diagnostics#4108) we should be able to make it work on every platform.