Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to RoslynToolchain #2409

Merged
merged 1 commit into from Sep 8, 2023
Merged

Conversation

timcassell
Copy link
Collaborator

Fixes #2405

@timcassell timcassell added this to the v0.13.8 milestone Aug 18, 2023
@adamsitnik
Copy link
Member

@ViktorHofer @ericstj do you know if it's possible to determine whether the Full .NET Framework exe that is currently being executed has been compiled using the classic project file (using packages.config etc)?

Context: when BDN needs to create and build a new exe we would prefer to use the modern project files.

@timcassell
Copy link
Collaborator Author

@adamsitnik The changes here basically just uses RoslynToolchain if there are no build settings changes, otherwise it will use CsProjClassicNetToolchain which will still fail with packages.config. It just fixes the default case (what first-time users will see).

I already have a working prototype that fixes using packages.config (along with a few other issues), but it relies on changes in #2393.

@ViktorHofer
Copy link
Member

@ViktorHofer @ericstj do you know if it's possible to determine whether the Full .NET Framework exe that is currently being executed has been compiled using the classic project file (using packages.config etc)?
Context: when BDN needs to create and build a new exe we would prefer to use the modern project files.

Unsure but I would surprised if so. The underlying build infrastructure (projejct-system format) shouldn't leak into the app's output.

@AndreyAkinshin AndreyAkinshin merged commit e2e888c into master Sep 8, 2023
12 checks passed
@AndreyAkinshin AndreyAkinshin deleted the default-roslyn-toolchain branch September 8, 2023 09:18
@AndreyAkinshin
Copy link
Member

@timcassell thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.13.7 BenchmarkDotNet.Autogenerated project fails build
4 participants