feat: add text justification style

[Vahdanian]

Hi, thanks for reviewing my pull request. This pull request intends to fix [https://github.com//issues/1995](this issue)

Here are some key points worth mentioning:
1- After initial investigation, I found that Justify property in "SummaryTableColumn" class does not have impact on aligning the contents of summary table. It only effects the header separator of table. (See the first attachment please)

2- I managed to add the "DefaultTextJustification" property to "SummaryStyle" and use the style to set "Justify" property inside "SummaryTableColumn". I changed the "BuildStandardText" and "BuildBoldText" methods to use "Justify" property.

3- Since I changed how the Justify Property was being initialized and the previous value was only used inside "GetJustificationIndicator" method, I changed the method to read from "IsNumeric" value of passed column. Exactly like the previous value of "Justify" property

4- I modified SummaryTableTests class and added a new method to MockFactory class to test the new style. CreateSummary method inside MockFactory did not used the specified style of config object and directly called the constructor of Summary class where style was initialized with default instance. So I added a new parameter for style.

5- Finally I modified methods "SummaryStyle" class and added a new method in "HashCode" struct to support the newly added style "DefaultTextJustification".

6- You can see the final result in second attachment.

[timcassell]

It looks strange to me that there is no space on the left when it's left-justified, but there is a space on the right when it's right-justified.

[Vahdanian]

@timcassell
Sorry to bother but I needed to ask. What do you suggest for the tests that use a predefined .txt files in "VerifiedFiles" directory to verify the output? I started to notice some of these tests are failing because of new justify style (You can find one here). Shall I update the txt files to expect columns to be justified to left by default? Or you have something else in mind? please let me know.

[timcassell]

Shall I update the txt files to expect columns to be justified to left by default?

That sound reasonable to me. Especially since the old test expects it (but seems broken currently).

[Vahdanian]

@timcassell
I separated styling for numeric and text columns and fixed broken tests, Can you review the changes?

[Vahdanian]

It looks strange to me that there is no space on the left when it's left-justified, but there is a space on the right when it's right-justified.

This is fixed in the second commit

[Vahdanian]

@timcassell
Hi, extra spaces are removed in 3d commit and numeric columns are now justified to right by default

[Vahdanian]

@timcassell
Do you have a clue why some of the tests failed? It says some of the memory diagnoser tests are failing but I checked them on my machine and they were fine.

[timcassell]

@timcassell Do you have a clue why some of the tests failed? It says some of the memory diagnoser tests are failing but I checked them on my machine and they were fine.

It's unrelated. Those tests are flaky.

[timcassell]

Thanks @Vahdanian!

[Vahdanian]

Thanks @Vahdanian!

You're very welcome! I'm glad I could contribute to the project 😄