Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Custom SimpleJob Id ignored #2491

Merged
merged 3 commits into from Jan 5, 2024

Conversation

MattFromRVA
Copy link
Contributor

Fixes #2473

@MattFromRVA
Copy link
Contributor Author

@dotnet-policy-service agree

@MattFromRVA MattFromRVA marked this pull request as draft January 2, 2024 17:06
@MattFromRVA MattFromRVA marked this pull request as ready for review January 3, 2024 19:16
@AndreyAkinshin AndreyAkinshin merged commit 2990951 into dotnet:master Jan 5, 2024
7 checks passed
@AndreyAkinshin AndreyAkinshin added this to the v0.13.12 milestone Jan 5, 2024
@AndreyAkinshin
Copy link
Member

@MattFromRVA thanks for the PR! Indeed, it's an unpleasant bug and it's nice to have it fixed.

P.S. A side note: the whole Characteristic* infrastructure is a huge technical debt introduced in 2016. Back in those times, I had no idea about the actual feature set we needed, so I tried to design a flexible and generic approach. Unfortunately, the API turned out to be over-complicated, which is quite challenging to maintain. In my backlog, I have a long-living task of burning Characteristic* and redesigning the Job API from scratch targeting the current set of features. However, this task is not product-critical (the current system just works most of the time), so it's always deprioritized (no ETA for now).

@MattFromRVA
Copy link
Contributor Author

MattFromRVA commented Jan 5, 2024

@AndreyAkinshin no problem! Thanks for the additional history. When that backlog item becomes a priority I would be happy to help contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom SimpleJob Id ignored when the MinIterationTime attribute is used.
2 participants