Provide more information in Desc structures #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the only use of OutputMode in PInvokeGenerator binding generation code. This is no place for hardcoding IOutputBuilder-specific logic.
andrew-boyarshin
force-pushed
the
layout_desc
branch
from
7ee0da5
to
98ab893
Compare
andrew-boyarshin
changed the title
Perksey
approved these changes
May 14, 2021
|
Sorry for the delay in getting this reviewed/merged. Could you rebase or merge this with the latest main so we can get updated CI results? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to provide more info to the
IOutputBuilderand enable generating e.g. additional attributes to be parsed out later.Drop the only use of OutputMode in PInvokeGenerator binding generation code. This is no place for hardcoding
IOutputBuilder-specific logic.