Handle virtual destructors #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeule
force-pushed
the
feature/virtual-dtor
branch
2 times, most recently
from
edb91fb
to
51c0e95
Compare
zeule
force-pushed
the
feature/virtual-dtor
branch
from
51c0e95
to
1e24dcf
Compare
This resolves crashing on virtual destructors if Clang is build with assertions and corrects vtbl indices for tables with destructors. Fixes dotnet#240.
zeule
force-pushed
the
feature/virtual-dtor
branch
from
1e24dcf
to
401e09f
Compare
tannergooding
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves crashing on virtual destructors if Clang is build with
assertions and corrects vtbl indices for tables with destructors.
Fixes #240.