Fix build with Clang 12 and install the native lib #244
Conversation
|
|
| clangAST | ||
| clangFrontend | ||
| libclang | ||
| ) |
There was a problem hiding this comment.
Can you provide more details about how you built such that you didn't have clangAST or clangFrontend?
These exist in both the official release binaries (https://github.com/llvm/llvm-project/releases/tag/llvmorg-12.0.0, see `lib/libclangAST.a and friends) and in the binaries produced if built locally.
There was a problem hiding this comment.
This CMake was also used to succesfully build libClangSharp for 12.0.0 on all supported platforms, so things were resolving correctly.
There was a problem hiding this comment.
Can you provide more details about how you built such that you didn't have clangAST or clangFrontend?
sys-devel/clang version 12.0.0 from the Gentoo main tree. Neither it nor the clang package from Arch provide those libraries. You can view the file list for the Arch package here.
The clang package here installs no static (.a) archives at all.
There was a problem hiding this comment.
There was a problem hiding this comment.
This looks like its going to break windows as there is no clang-cpp produced.
I'm fine with taking it for Unix given it looks like the official binaries do create and ship clang-cpp by default.
There was a problem hiding this comment.
Updated adding library check.
zeule
force-pushed
the
feature/install-native-lib
branch
2 times, most recently
from
56e1701
to
7901a36
Compare
|
Added |
zeule
force-pushed
the
feature/install-native-lib
branch
from
7901a36
to
2764e96
Compare
No, that's unneeded, the import library path is set correctly by Clang's Targets.cmake. |
| SOVERSION ${PROJECT_VERSION} | ||
| ) | ||
|
|
||
| include(GNUInstallDirs) |
There was a problem hiding this comment.
What's the behavior of this on Windows and is it going to do the "right" thing where Windows considers *.dll a bin file but *.lib a library file (in contrast to Unix which considers both *.so and *.a to be library files)?
There was a problem hiding this comment.
On Windows _BINDIR is "bin", _LIBDIR is "lib", .dll files are RUNTIME, .lib files are ARCHIVE. CMake documents that here.
Closes #241.