Add Preprocessing Wrappers #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sources/ClangSharp/Cursors/Cursor.cs
Outdated
| @@ -80,6 +80,10 @@ internal static Cursor Create(CXCursor handle) | |||
| { | |||
| result = Attr.Create(handle); | |||
| } | |||
| else if (handle.IsPreprocessing) | |||
| { | |||
| result = Preprocessing.Create(handle); | |||
There was a problem hiding this comment.
nit: I've tried to mirror the Clang C++ API structure where applicable.
In this case, it would be:
class PreprocessedEntity : Cursor { }
class MacroExpansion : PreprocessedEntity { }
class PreprocessingDirective : PreprocessedEntity { }
class InclusionDirective : PreprocessingDirective { }
class MacroDefinitionRecord : PreprocessingDirective { }There was a problem hiding this comment.
Following the C++ API gives a structured layout that closely mirrors the actual OOP API design and allows various bits of code to be shared where it makes sense due to the backing data the cursor handles represent
|
Overall LGTM. Just a nit about the layout of the types. |
|
@tannergooding Thank you for the review. |
tannergooding
approved these changes
Aug 19, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added few wrapper classes to handle preprocessing cursors..