-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.125.4 dockerClient.System.GetSystemInfoAsync() JsonSerializationException #458
Comments
Getting the same error with Swarm.ListNodesAsync() in version 3.125.4 |
In this class here: https://github.com/dotnet/Docker.DotNet/blob/master/src/Docker.DotNet/Models/TLSInfo.Generated.cs CertIssuerSubject is a List It appears in the JSON returned from the docker engine as a string: "CertIssuerSubject": "MBMxETAPBgNVBAMTCHN3YXJtLWNh" Not sure why this is being deserialised to a list of bytes. |
hi, Can you please possibly do a fix? Thanks in advance. |
The JSON models are generated, does anyone know how this is done? |
Why not just download the code and fix it locally by changing CertIssuerPublicKey to string in Docker.DotNet.Models TLSInfo class. I'm not sure this is the right way, but it works for me. |
Yeah that will fix it, but I don't think that change would get merged in if you submitted a pull request. That class is code generated based off the docker API schema. Edit: I'll just submit one and we'll see what happens. This really needs to be fixed, the repo is broken and the previous version is missing quite a few features. |
I just submitted this pull request: #469 |
@thnk2wn this should have be fixed in last version as @The-TT-Hacker contribution has been merged |
It is fixed on master branch. Include the library not from nuget but from source code
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Markus Lippert ***@***.***>
Sent: Sunday, March 28, 2021 3:30:25 PM
To: dotnet/Docker.DotNet ***@***.***>
Cc: David García Vives ***@***.***>; Mention ***@***.***>
Subject: Re: [dotnet/Docker.DotNet] 3.125.4 dockerClient.System.GetSystemInfoAsync() JsonSerializationException (#458)
@dgvives<https://github.com/dgvives> how can we bring #469<#469> forward? This is a blocking issue for me
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#458 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARATUNYLCWOV6PK7ZCZCCDLTF44QDANCNFSM4P6Y73LQ>.
|
Any update about when a fix for this issue is going to be released? |
I also would love to see the fix in a versioned package on nuget.org. |
Upgraded Docker.Net from
3.125.2
to3.125.4
. Now getting aJsonSerializationException
when callingdockerClient.System.GetSystemInfoAsync()
.Output of
dotnet --info
:What version of Docker.DotNet?:
Steps to reproduce the issue:
SystemInfoResponse systemInfo = await _dockerClient.System.GetSystemInfoAsync();
What actually happened?:
Received error:
What did you expect to happen?:
Expected populated docker system info object that the last version returned.
Additional information:
Platform:
Microsoft Windows 10.0.19041
Not sure if it's relevant but do have these versions of Newtonsoft.Json in the same project:
Docker system info:
docker-system-info.json.txt
The text was updated successfully, but these errors were encountered: