Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RestartPolicy parameter to Create Container #8

Closed
ahmetb opened this issue Oct 6, 2014 · 12 comments
Closed

Add RestartPolicy parameter to Create Container #8

ahmetb opened this issue Oct 6, 2014 · 12 comments

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Oct 6, 2014

This has just randomly showed up in API 1.14 docs. I am not even sure why they modify docs after releasing it. It surely wasn't there before... https://docs.docker.com/reference/api/docker_remote_api_v1.14/#create-a-container

@jgarverick
Copy link
Contributor

Well that's annoying. I would have remembered seeing that. Want me to roll
that in as well?

On Monday, October 6, 2014, Ahmet Alp Balkan notifications@github.com
wrote:

This has just randomly showed up in API 1.14 docs. I am not even sure why
they modify docs after releasing it. It surely wasn't there before...
https://docs.docker.com/reference/api/docker_remote_api_v1.14/#create-a-container

https://camo.githubusercontent.com/65bde9c77c08947cf709d57f4ffa9d651727a2ba/687474703a2f2f636c2e6c792f696d6167652f32553331304130423352307a2f496d616765253230323031342d31302d30362532306174253230332e34322e3031253230504d2e706e67


Reply to this email directly or view it on GitHub
#8.

@ahmetb
Copy link
Contributor Author

ahmetb commented Oct 6, 2014

That needs to be tested as well. If you'd like to work on it, you can send a separate CR off from clean dev branch.

@jgarverick
Copy link
Contributor

Understood.

On Monday, October 6, 2014, Ahmet Alp Balkan notifications@github.com
wrote:

That needs to be tested as well. If you'd like to work on it, you can send
a separate CR off from clean dev branch.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@ahmetb ahmetb added this to the v1.1.1 milestone Oct 7, 2014
@jgarverick
Copy link
Contributor

I'll be submitting a PR for this shortly.

@ahmetb
Copy link
Contributor Author

ahmetb commented Oct 16, 2014

@jgarverick based on the revelations from the issue on docker/docker, will you be updating the code? thanks.

@jgarverick
Copy link
Contributor

Since this particular change isn't due to go in until v1.3 (API v1.15), I
can let this stand until the next Docker release. Or, if you like, I can
close this PR and submit a fresh one when the version rolls. I'm happy to
do either, though I'd prefer to wait until they officially release it in
case anything inadvertently changes.

On Thu, Oct 16, 2014 at 2:47 AM, Ahmet Alp Balkan notifications@github.com
wrote:

@jgarverick https://github.com/jgarverick based on the revelations from
the issue on docker/docker, will you be updating the code? thanks.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@ahmetb
Copy link
Contributor Author

ahmetb commented Oct 16, 2014

You're so lucky 1.3 is released today! :-)

@jgarverick
Copy link
Contributor

Who would have thought? I'm on it.

On Thursday, October 16, 2014, Ahmet Alp Balkan notifications@github.com
wrote:

You're so lucky 1.3 is released today! :-)


Reply to this email directly or view it on GitHub
#8 (comment)
.

@jgarverick
Copy link
Contributor

This has been checked in and tested. Should be good to go. LMK if you
have questions/issues. Thanks!

On Thu, Oct 16, 2014 at 7:28 PM, Josh Garverick josh.garverick@gmail.com
wrote:

Who would have thought? I'm on it.

On Thursday, October 16, 2014, Ahmet Alp Balkan notifications@github.com
wrote:

You're so lucky 1.3 is released today! :-)


Reply to this email directly or view it on GitHub
#8 (comment)
.

@ahmetb
Copy link
Contributor Author

ahmetb commented Oct 21, 2014

Great, I have a few changes that I need to make about creation of restartpolicy object. I believe I will just merge yours and apply on top of it. Thanks

On Tue, Oct 21, 2014 at 10:43 AM, Josh Garverick notifications@github.com
wrote:

This has been checked in and tested. Should be good to go. LMK if you
have questions/issues. Thanks!
On Thu, Oct 16, 2014 at 7:28 PM, Josh Garverick josh.garverick@gmail.com
wrote:

Who would have thought? I'm on it.

On Thursday, October 16, 2014, Ahmet Alp Balkan notifications@github.com
wrote:

You're so lucky 1.3 is released today! :-)


Reply to this email directly or view it on GitHub
#8 (comment)
.


Reply to this email directly or view it on GitHub:
#8 (comment)

@jgarverick
Copy link
Contributor

Sounds good. Cheers!

On Tuesday, October 21, 2014, Ahmet Alp Balkan notifications@github.com
wrote:

Great, I have a few changes that I need to make about creation of
restartpolicy object. I believe I will just merge yours and apply on top of
it. Thanks

—Alp
http://alp.im

On Tue, Oct 21, 2014 at 10:43 AM, Josh Garverick <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

This has been checked in and tested. Should be good to go. LMK if you
have questions/issues. Thanks!
On Thu, Oct 16, 2014 at 7:28 PM, Josh Garverick <
josh.garverick@gmail.com
javascript:_e(%7B%7D,'cvml','josh.garverick@gmail.com');>
wrote:

Who would have thought? I'm on it.

On Thursday, October 16, 2014, Ahmet Alp Balkan <
notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

You're so lucky 1.3 is released today! :-)


Reply to this email directly or view it on GitHub
<
https://github.com/ahmetalpbalkan/Docker.DotNet/issues/8#issuecomment-59446365>

.


Reply to this email directly or view it on GitHub:

#8 (comment)


Reply to this email directly or view it on GitHub
#8 (comment)
.

@ahmetb
Copy link
Contributor Author

ahmetb commented Aug 25, 2015

Fixed now in v1.1.2.1.

@ahmetb ahmetb closed this as completed Aug 25, 2015
Emdot added a commit to Emdot/Docker.DotNet that referenced this issue Feb 26, 2021
Setup to generate documentation
Emdot added a commit to Emdot/Docker.DotNet that referenced this issue Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants