Added MultiplexedStreamReader #473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgvives
reviewed
Feb 17, 2021
| var line = new List<byte>(); | ||
|
|
||
| var buffer = new byte[1]; | ||
|
|
There was a problem hiding this comment.
@The-TT-Hacker I tested this method trying to get rid of headers being shown on MonitorStreamAsync method and haven't managed to cancel it.
Would you confirm if expected behaviour is to read until 0 bytes are returned or to stop reading when no more lines are retrieved?
When res equals 0, it loops indefinitelly.
This is test I used
https://gist.github.com/dgvives/2620960049191797ea0d871c339d9bc2#file-program-cs-L1
It would be nice if MultiplexedStreamReader could detect stream being multiplexed and provide output por ReadLineAsync without control chars.
Have you checked this running containers on different platforms? Because of EOL
|
@galvesribeiro I have updated this one with cancellation support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple reader for the multiplexed stream used for getting logs from containers which can read lines as strings. Also works with the service logs pull request i've made.
Ideally the multiplex stream would extend the stream class or something so we can use the normal stream reader but this is working for me.