Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to v1.24 of Docker engine api #50

Merged
merged 22 commits into from
Apr 27, 2016
Merged

Updating to v1.24 of Docker engine api #50

merged 22 commits into from
Apr 27, 2016

Conversation

swernli
Copy link
Collaborator

@swernli swernli commented Apr 26, 2016

The big kahuna.

jterry75 and others added 20 commits March 17, 2016 11:50
…on so that git submodule support is possible

Signed-off-by: Justin Terry <juterry@microsoft.com>
Signed-off-by: Justin Terry <juterry@microsoft.com>
Adding support for dotnet cli
…ort. Autogenerates the models based on the gocode.

Signed-off-by: Justin Terry <juterry@microsoft.com>
Signed-off-by: Justin Terry <juterry@microsoft.com>
…ge of the 2 release and bring the v1.24 support from docker

Signed-off-by: Justin Terry <juterry@microsoft.com>
…l basetype structs.

2. Updated the dependency graph to build such base types to enable the sharing.
3. Fixed the using imports to only generate what is actually referenced.
4. Added a couple of customization modifications to use enums where possible over string/int values.

Signed-off-by: Justin Terry <juterry@microsoft.com>
Update full docker.net api version
… use.

Signed-off-by: Stefan J. Wernli <swernli@microsoft.com>
Adding project.json for X509 and updating the constructors
Signed-off-by: Stefan J. Wernli <swernli@microsoft.com>
Cleaning up unnecessary using statements.
…g, object> so it doesnt fail when empty

Signed-off-by: Justin Terry <juterry@microsoft.com>
Fixing support for map[string]struct{} generation to dictionary<strin…
Signed-off-by: Justin Terry <juterry@microsoft.com>
Exposing the network operations to the DockerClient
Signed-off-by: Justin Terry <juterry@microsoft.com>
… few.

Signed-off-by: Justin Terry <juterry@microsoft.com>
Fixing a few bugs in the generated code types.
Signed-off-by: Stefan J. Wernli <swernli@microsoft.com>
@ahmetb
Copy link
Contributor

ahmetb commented Apr 26, 2016

@swernli awesome I think I'll just merge that. can you please update CHANGELOG in readme and tell me what to call this version? Should we update the nuget as well or should we do it after the transfer (I think I should transfer NuGet ownership to you as well).

@jgarverick
Copy link
Contributor

This is fantastic! @ahmetalpbalkan did I read that correctly--stepping away as the primary?

Signed-off-by: Justin Terry <juterry@microsoft.com>
@ahmetb
Copy link
Contributor

ahmetb commented Apr 26, 2016

@jgarverick yes! Windows team has developed tools to keep the API compatibility up to date with Docker codebase and they developed https://github.com/Microsoft/Docker-PowerShell/ using this. Many more Microsoft teams started to take dependency on this repo.

We are hoping to graduate this into an official repository under Microsoft's GitHub org.

@swernli
Copy link
Collaborator Author

swernli commented Apr 27, 2016

@ahmetalpbalkan I updated the changelog. The version we've been using for this is 2.124 (major version bump to indicate a breaking change, and the minor version shows the Engine API it targets). That would be my suggestion for a tag/release.

@swernli
Copy link
Collaborator Author

swernli commented Apr 27, 2016

@jterry75 FYI :)

@jstarks
Copy link
Collaborator

jstarks commented Apr 27, 2016

@jterry75 Are we putting the generator in yet? We shouldn't keep that private.

@jgarverick
Copy link
Contributor

That's awesome, Ahmet. Glad I could pitch in when I could. 😊

-----Original Message-----
From: "Ahmet Alp Balkan" notifications@github.com
Sent: ‎4/‎26/‎2016 7:57 PM
To: "ahmetalpbalkan/Docker.DotNet" Docker.DotNet@noreply.github.com
Cc: "Josh Garverick" josh.garverick@gmail.com; "Mention" mention@noreply.github.com
Subject: Re: [ahmetalpbalkan/Docker.DotNet] Updating to v1.24 of Docker engineapi (#50)

@jgarverick yes! Windows team has developed tools to keep the API compatibility up to date with Docker codebase and they developed https://github.com/Microsoft/Docker-PowerShell/ using this. Many more Microsoft teams started to take dependency on this repo.
We are hoping to graduate this into an official repository under Microsoft's GitHub org.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@ahmetb ahmetb merged commit c4e220c into dotnet:master Apr 27, 2016
@ahmetb
Copy link
Contributor

ahmetb commented Apr 27, 2016

@swernli @jterry75 merged and tagged. If one of you could go over the README and fix the sample code (I'm assuming something must have changed) that would be great!

@jgarverick we always appreciate your contributions!

@jterry75
Copy link
Contributor

@jstarks Yes the generator is going to be added ASAP. Just wasn't ready for this PR.

mdarocha pushed a commit to TrapTech/Docker.DotNet that referenced this pull request Jul 11, 2022
Merge changes from master to develop branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants