Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copyedit comment on IContainerOperations.AttachContainerAsync() #616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

copyedit comment on IContainerOperations.AttachContainerAsync() #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Docker.DotNet/Endpoints/IContainerOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,8 @@ public interface IContainerOperations
/// <param name="cancellationToken">When triggered, the operation will stop at the next available time, if possible.</param>
/// <returns>A <see cref="Task{TResult}"/> that resolves to a <see cref="MultiplexedStream"/>, which contains the
/// container's <c>stdout</c> and <c>stderr</c> content and which can be used to write to the container's <c>stdin</c>.</returns>
/// <remarks>The format of the stream various, in part by the <paramref name="tty"/> parameter's value. See the
/// <a href="https://docs.docker.com/engine/api/v1.41/#operations/ContainerAttach">Docker Engine API reference</a> for details on
/// <remarks>The format of the stream varies depending on the <paramref name="tty"/> parameter's value and some other factors.
/// See the<a href="https://docs.docker.com/engine/api/v1.41/#operations/ContainerAttach">Docker Engine API reference</a> for details on
Comment on lines +310 to +311
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <remarks>The format of the stream varies depending on the <paramref name="tty"/> parameter's value and some other factors.
/// See the<a href="https://docs.docker.com/engine/api/v1.41/#operations/ContainerAttach">Docker Engine API reference</a> for details on
/// <remarks>The format of the stream varies depending on the <paramref name="tty"/> parameter's value.
/// See the<a href="https://docs.docker.com/engine/api/v1.41/#operations/ContainerAttach">Docker Engine API reference</a> for details on

/// the format.</remarks>
/// <remarks>The corresponding commands in the Docker CLI are <c>docker attach</c> and <c>docker container attach</c>.</remarks>
/// <exception cref="DockerContainerNotFoundException">No such container was found.</exception>
Expand Down