Migrate from Newtonsoft.Json to System.Text.Json #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, in commit 6a87013 I improved all the HTTP requests to deserialize the JSON payload directly from the HTTP response stream instead of reading the response as string then deserializing to model objects. This is an improvement in both speed and memory allocations. |
dgvives
reviewed
May 4, 2024
| using (var stream = await streamTask) | ||
| using (var reader = new StreamReader(stream, new UTF8Encoding(false))) | ||
| using (var jsonReader = new JsonTextReader(reader) { SupportMultipleContent = true }) | ||
| using (cancellationToken.Register(() => tcs.TrySetCanceled(cancellationToken))) | ||
| { |
There was a problem hiding this comment.
Verify this task can be cancelled by running the test CreateContainerAsync_TimeoutExpires_Fails.
There was a problem hiding this comment.
I removed the Skip reason and I can confirm that the tests with the 3 different timeouts are passing. ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is now truly async, no more fake
Task.Factory.StartNewasync.