Fix breadcrumbs #136
Open
Fix breadcrumbs #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rick-Anderson @gewarren Please review, thanks! |
|
@raprice I'm not sure that this is working how you want it to work. For example compare these two pages: |
|
@gewarren You're absolutely right, something is funky. I will dig into this, putting back in draft until I get this rendering correctly. Thanks for catching it! |
|
dotnet/entityframework.apidocs |
|
@gewarren Please take a look - the breadcrumbs from this PR are now rendering correctly (Learn / .NET / Entity Framework / .NET API browser) https://review.learn.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore?view=efcore-8.0&branch=pr-en-us-136 |
gewarren
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings breadcrumb implementation into alignment with platform architecture requirements. This PR is part of a previously announced batch of breadcrumb fixes across the Learn platform and will be auto-merged if there are no build warnings. This PR may include removing the “extend breadcrumb” feature from any docfx files that are still using it, fixing breadcrumb file references in the docfx file, and rewriting breadcrumb files to match the approved breadcrumb pattern for a given product’s documentation.