turn off edit button #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is probably fine, however even if we never actually merge a PR, perhaps there isn't an easier way for customers to let us know whenever we have a typo or other problem in our API docs. Cc @aspnet/efteam so that they can decide. |
|
You could enable feedback if you wanted. That's another option. |
|
Makes sense to me - disable edit, enable feedback. I think I even saw a bot somewhere that automatically closes PRs with an explanatory message (since IIRC github doesn't allow disabling PRs). |
|
We'll need to enable an app first on the repo but I'll make the changes. |
|
I checked and you already have feedback enabled, so you can just merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @divega on PR #50, this repo is not supposed to accept external contributions because the content is auto-generated from source.
So removing the edit button from docs would help with not getting unwanted PRs here.