Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings for deterministic ordering #3685

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

roji
Copy link
Member

@roji roji commented Jan 19, 2022

In split query, and also a stronger note in the pagination page.

Closes #3242

In split query, and also a stronger note in the pagination page.

Closes dotnet#3242
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no issue of deterministic ordering.

@roji
Copy link
Member Author

roji commented Jan 24, 2022

@smitpatel then please propose another warning text, I don't mind.

@smitpatel
Copy link
Member

We already discussed that in teams chat.

@roji
Copy link
Member Author

roji commented Jan 24, 2022

I pushed this commit as a result of that discussion, believing that's what you wanted. If it isn't, just propose whatever you think is right.

@smitpatel
Copy link
Member

Pagination queries without explicit ordering causes non-deterministic result set is right. (though non-pagination page should mention pagination, we discussed that pagination doesn't required to mentioned on the page which talks about pagination). But the main issue remains, there is no non-deterministic ordering, there is only non-deterministic result set.

If you want me to update the message, just assign the issue to me. I will get around to it at some point.

@roji
Copy link
Member Author

roji commented Jan 24, 2022

But the main issue remains, there is no non-deterministic ordering, there is only non-deterministic result set.

I don't see it that way: a query whose orderings can produce different resultsets (because of lack of a unique column) can be said to have non-deterministic ordering.

But I'll close this and let you deal with this whichever way you want.

@roji roji closed this Jan 24, 2022
@ajcvickers ajcvickers reopened this Jan 27, 2022
@ajcvickers ajcvickers self-requested a review January 27, 2022 13:15
@ajcvickers
Copy link
Member

@smitpatel Can you sign off on this so I can merge?

@ajcvickers ajcvickers merged commit 80c51a3 into dotnet:main Jan 31, 2022
@roji roji deleted the NonDeterministicQueries branch July 26, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document behavior of AsSplitQuery() when subquery has unstable ordering
3 participants