-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings for deterministic ordering #3685
Conversation
In split query, and also a stronger note in the pagination page. Closes dotnet#3242
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no issue of deterministic ordering.
@smitpatel then please propose another warning text, I don't mind. |
We already discussed that in teams chat. |
I pushed this commit as a result of that discussion, believing that's what you wanted. If it isn't, just propose whatever you think is right. |
Pagination queries without explicit ordering causes non-deterministic result set is right. (though non-pagination page should mention pagination, we discussed that pagination doesn't required to mentioned on the page which talks about pagination). But the main issue remains, there is no non-deterministic ordering, there is only non-deterministic result set. If you want me to update the message, just assign the issue to me. I will get around to it at some point. |
I don't see it that way: a query whose orderings can produce different resultsets (because of lack of a unique column) can be said to have non-deterministic ordering. But I'll close this and let you deal with this whichever way you want. |
@smitpatel Can you sign off on this so I can merge? |
In split query, and also a stronger note in the pagination page.
Closes #3242