Add support for netstandard2.0 #51
Conversation
|
It would be good to add a way to test both branches of code in the unit test, as I can't easily tell which branch of code unit tests go down... Thoughts? |
|
It occurs to me that perhaps we don't even need netcoreapp2.1 as part of the project. I'm not sure what benefits are gained by having both, since netcoreapp2.1 will happily work with standard? That would at least simplify testing greatly. |
|
I didn't wanna fully switch to netstandard because netcoreapp methods are more efficient as they take direct use of memory object where i had to do array copying in a few places. But honestly in context of getting a token, that's an optimization that won't affect anything in meaningful way so I'm happy to just target netstandard20 and drop netcoreapp to keep things simple |
|
Let's cut netcoreapp2.1 then. I'm not confident the original implementation that uses the new stuff is written correctly as far as performance goes anyway. :) |
|
Should be good to merge now. I ripped out netcoreapp21 dependency |
No description provided.