implement missing apis #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return span.Slice(0, span.IndexOf((byte)'\0')).AsString(); | ||
| } | ||
|
|
||
| public bool EmitToFile(LLVMModuleRef module, string fileName, LLVMCodeGenFileType codegen, out string message) |
There was a problem hiding this comment.
nit: This should be TryEmitToFile and there should optionally be a corresponding string EmitToFile which throws on failure (this follows the .NET Framework design guidelines).
There was a problem hiding this comment.
@tannergooding Thanks fixed
| { | ||
| sbyte* pMessage; | ||
|
|
||
| int result = LLVM.TargetMachineEmitToFile(this, module, marshaledFileName, codegen, &pMessage); |
There was a problem hiding this comment.
Based on the docs, we need to call LLVMDisposeMessage on errorMessage after marshaling it to managed code. It would probably be good to explicitly call it errorMessage as well, so it is clear to the consumer its intent.
Otherwise, the changes LGTM. Thanks!
There was a problem hiding this comment.
@tannergooding thanks fixed
tannergooding
approved these changes
Aug 19, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing apis while porting some of my code from https://www.nuget.org/packages/swigged.llvm/
to LLVMSharp v8