This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
WinForms.GDI Sample: Add Scrolling #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the split panel scrollable (to the size of the selected Scenario). This improves the window, but not all Scenario objects have accurate dimensions presently. Changes in the designer files (indentation and deletion of comments) were performed automatically by the visual Visual Studio 2022 (preview) editor.
eliminates rendering artifacts observed when scrolling or resizing the window
The background of the scrollpanel containing the graphics view is now ControlDark so when a Scenario is loaded its obvious how large it is (it resembles a white page on a light gray backdrop)
This scenario draws 1px thick lines at the edges of the canvas. This can be used to confirm that rendering does not crop or extend beyond the canvas. This scenario is useful verifying that dirty rectangle size and placement on the window is accurate to the pixel.
jonlipsky
approved these changes
Oct 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the WinForms GDI control and sample application:
AbstractScenario)OnPaint()dirty rectangle was expanded by 1 pixel to eliminate rendering artifactsDimensionCheckAbstractScenarioconfirms the dirty rectangle is pixel-perfectIf this PR is positively received I can create separate PRs which:
AbstractScenariosizes by correcting the dimensions they pass into theirbaseinitializersDemonstration
Originally it's difficult to view the whole canvas
Enabling AutoScroll works, but caused render artifacts
It looks good after expanding the dirty rectangle by 1px on all sides
This
AbstractScenariois improperly sized (which is why it won't scroll to the bottom). I can fix these in a separate PR.Dimension Test Scenario
This new Scenario confirms the dirty rectangle is pixel-perfect. Too small and the black lines would get cut-off. Too large and there would be a white border.