This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
[GDI.WinForms] fix rounded rectangles #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic so drawing or filling rounded rectangles with zero radius calls the regular rectangle methods (previously an exception was thrown)
Added (or simplified) logic to ensure the radius of a rounded rectangle is never larger than the rectangle itself, fixing rendering artifacts that previously occurred with filled rounded rectangles.
swharden
changed the title
The AddArc() call draws a circle inside a bounding rectangle, and its arguments expect the size of the rectangle (not half its size). This fix brings the GDI rectangle shapes rendered into agreement with the Skia control.
|
@swharden Thanks so much for this!!! |
jonlipsky
approved these changes
Oct 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves GDI support for rounded rectangles by preventing exceptions when a radius of 0 is used. Some of the test scenarios test for this, resulting in a crash, and preventing the scenarios from completing.
Although this PR prevents the exception and allows the tests to complete, rounded rectangles still don't render properly on GDI. I may fix that in a separate PR, but for now not crashing the scenario seems like a good improvement 馃槄EDIT: the rendering errors were pretty easy to fix, so I fixed those in this PR too. Also note that
AddArc()expects a circle's bounding box size (its diameter), not its radius, so this PR fixes that too to bring the GDI images into agreement with Skia's 馃憤Example: Radius < Height
Example: Radius > Height