Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot navigate back after nested Shell navigations #299

Open
Dreamescaper opened this issue Jan 17, 2021 · 6 comments
Open

Cannot navigate back after nested Shell navigations #299

Dreamescaper opened this issue Jan 17, 2021 · 6 comments

Comments

@Dreamescaper
Copy link
Contributor

Dreamescaper commented Jan 17, 2021

If I navigate to some page using ShellNavigationManager, and then navigate again to some third page, I cannot go back from that page - back button has no effect.

Example in ControlGallery:
Skia Playground -> Skia Canvas Paths.

Attempt to execute Shell.Current.Navigation.PopAsync leads to an error (sorry for screenshot):

Error

image

(Issue reproduces on older commits as well, so not related to #298 )

@Dreamescaper
Copy link
Contributor Author

Seems like the cause of the issue is Xamarin.Forms upgrade - I cannot reproduce on older commits.

@Dreamescaper
Copy link
Contributor Author

Probably should be fixed by this PR:
xamarin/Xamarin.Forms#13330

So probably simply need to wait for Xamarin.Forms update.

@Dreamescaper
Copy link
Contributor Author

Dreamescaper commented Jan 18, 2021

Tested on latest Xamarin.Forms nightly - issue does not reproduce there.

@Eilon
Copy link
Member

Eilon commented Jan 18, 2021

So we still need another bug fix from Xamarin.Forms possibly (if so, is there a bug filed on it)? Or do we need to investigate further to see if MBB is doing something wrong?

@Dreamescaper
Copy link
Contributor Author

Sorry, my bad, I've lost "not" in the previous comment :).

I don't think anything is required (apart from updating XF when it releases).

@Eilon
Copy link
Member

Eilon commented Jan 18, 2021

Got it! So we'll hold onto this bug until we can pull in an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants