This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix Shell Navigation for Hierarchally registered Global Routes #13330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
blocker
PureWeen
commented
Jan 8, 2021
| namespace Xamarin.Forms | ||
| { | ||
| [DebuggerDisplay("RequestDefinition = {Request}, StackRequest = {StackRequest}")] | ||
| internal class NavigationRequest |
There was a problem hiding this comment.
No changes here just moving this class to its own file
PureWeen
commented
Jan 8, 2021
| [DebuggerDisplay("Full = {FullUri}, Short = {ShortUri}")] | ||
| internal class RequestDefinition | ||
| { | ||
| public RequestDefinition(RouteRequestBuilder theWinningRoute, Shell shell) |
There was a problem hiding this comment.
No changes here just moving this class to its own file
PureWeen
commented
Jan 8, 2021
| /// <summary> | ||
| /// This attempts to locate the intended route trying to be navigated to | ||
| /// </summary> | ||
| internal class RouteRequestBuilder |
There was a problem hiding this comment.
No changes here just moving this class to its own file
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
PureWeen
removed
the
DO-NOT-MERGE-!!! 🛑
PureWeen
requested review from
jsuarezruiz and
hartez
and removed request for
rmarinho
|
Failing Tests are unrelated |
hartez
approved these changes
Jan 14, 2021
PureWeen
commented
Jan 15, 2021
|
|
||
| List<string> CollapsePath( |
There was a problem hiding this comment.
This good just got moved to ShellUriHandler.CollapsePath
PureWeen
commented
Jan 15, 2021
| @@ -475,24 +475,6 @@ void RemoveExcessPathsWithinTheRoute() | |||
| } | |||
| } | |||
|
|
|||
| List<Page> BuildFlattenedNavigationStack(List<Page> startingList, IReadOnlyList<Page> modalStack) | |||
There was a problem hiding this comment.
This code just got moved to ShellNavigationManager.BuildFlattenedNavigationStack
rmarinho
approved these changes
Jan 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed Hierarchical Global Route Registration so that it would correctly apply the route registered to the current state of shell
If a user is registering full route path
Route.Register("path1/path2/path3")and Shell is currently at"path1/path2"Then the user should be able to navigate to that route via
GotoAsync("path3")orRoute.Register("path1/path2/path3")Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist