Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix src work if NETCore3.0 not installed #55

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Fix src work if NETCore3.0 not installed #55

merged 2 commits into from
Jan 23, 2020

Conversation

0x414c49
Copy link
Contributor

If you have installed .NET Core 3.1 but not 3.0 the source wouldn't load inside Visual Studio. By adding "rollForward": "minor" to global.json file, Visual Studio could find the 3.1 SDK.
https://docs.microsoft.com/en-us/dotnet/core/tools/global-json?tabs=netcore3x#rollforward

The source rebuilt successfully with .NET Core SDK 3.1.

If you have installed .NET Core 3.1 but not 3.0 the source wouldn't load inside Visual Studio. By adding "rollForward": "minor" to global.json file, Visual Studio could find the 3.1 SDK.

https://docs.microsoft.com/en-us/dotnet/core/tools/global-json?tabs=netcore3x#rollforward
@0x414c49 0x414c49 requested a review from Eilon January 22, 2020 09:13
Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Eilon Eilon merged commit 0091ac1 into dotnet:master Jan 23, 2020
@Eilon
Copy link
Member

Eilon commented Jan 23, 2020

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants