Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: CloudBuild: Include all variables #178

Closed
clairernovotny opened this issue May 18, 2018 · 3 comments
Closed

Docs: CloudBuild: Include all variables #178

clairernovotny opened this issue May 18, 2018 · 3 comments

Comments

@clairernovotny
Copy link
Member

Today, the cloudbuild, set variables option sets three variables. Would it make sense to set all of them and not just those three? There's various reasons they could be useful and it'd reduce the need to call the PowerShell version directly if everything was set as an env variable.
@AArnott
Copy link
Collaborator

AArnott commented May 18, 2018

Isn't this a dupe of #130 which is already fixed?

@clairernovotny
Copy link
Member Author

You're right. I missed it because it's not documented here:
https://github.com/AArnott/Nerdbank.GitVersioning/blob/master/doc/cloudbuild.md

setAllVariables

@clairernovotny clairernovotny changed the title CloudBuild: Include all variables Docs: CloudBuild: Include all variables May 18, 2018
AArnott added a commit that referenced this issue May 18, 2018
@AArnott
Document cloudBuild.setAllVariables field
4912c77 
Fixes #178
@AArnott AArnott mentioned this issue May 18, 2018
Merged
@AArnott
Copy link
Collaborator

AArnott commented May 18, 2018

Care to review #179, @onovotny?

AArnott added a commit that referenced this issue Feb 8, 2023
@AArnott
Merge pull request #178 from AArnott/net7.0sdk
3a23855 
Adopt .NET 7 SDK and NuGet central package versioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AArnott @clairernovotny