Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuration for which field sets the version #182

Open
clairernovotny opened this issue May 20, 2018 · 3 comments
Open

Support configuration for which field sets the version #182

clairernovotny opened this issue May 20, 2018 · 3 comments

Comments

@clairernovotny
Copy link
Member

It would be useful if there was a way to specify which of the NB.GV fields is used for the CloudBuildNumber, Version, PackageVersion and Version fields. It can default to what it does today, but there may be times when it's needed to override them.

Today, that means messing with MSBuild: https://github.com/onovotny/bc-csharp/blob/netstandard/scripts/setversion.csproj#L12-L19

If there's a .NET Core Global Tool (#181), that manipulation option isn't available.
@AArnott
Copy link
Collaborator

AArnott commented Jun 11, 2019

When is PackageVersion not providing the right package version?
Is this still an issue?

@AArnott
Copy link
Collaborator

AArnott commented Dec 20, 2019

Closing due to no response.

@AArnott AArnott closed this as completed Dec 20, 2019
@clairernovotny
Copy link
Member Author

This would address the four part version issue by making it configurable.

@AArnott AArnott reopened this Dec 21, 2019
AArnott pushed a commit that referenced this issue Feb 8, 2023
@dependabot
Bump Microsoft.CodeCoverage (#182)
a32f820 
Bumps [Microsoft.CodeCoverage](https://github.com/microsoft/vstest) from 17.5.0-preview-20221109-01 to 17.5.0-preview-20221201-01.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/commits)

---
updated-dependencies:
- dependency-name: Microsoft.CodeCoverage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AArnott @clairernovotny