-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nbgv cloud variables #193
Comments
I think the scenario here should be to remove the need for a dummy project or a special project as described here: The default version.json wouldn't have any cloud build numbers enabled, but a user could call the nbgv command in the build script. It can set the default CloudBuildNumber, override that with -v (works today). New, to add, it can do the set cloud vars and set all vars. Open question is what the default should be. Any reason not to set everything and have opt-out options? |
Not sure if I'm using it wrong, but it's not detecting/setting the version correctly: https://dotnetfoundation.visualstudio.com/Humanizer/_build/results?buildId=2573&view=logs I'm using it here: I've tried it with and without specifying the working directory (where the version.json is) |
Given the version.json already influences the version and can specify whether all cloud build variables are set (even if overall it is not enabled) how about the default being what the json prescribes? |
Fair enough, though that makes it a bit non-deterministic from looking only at the command line params. I don't know how it feels to have the default options controlled by that, which could easily be different per project. It seems line the command line should be explicit one way or the other? |
Fair point. I'll plan to make a consistent default. |
I found the bug that prevented |
Fix is now published to nuget.org as v2.1.65 |
Add ASP.NET Core runtime installation support
Add options to set basic cloud build variables as well as "all" variables.
Alternatively, just do what is specified in version.json file, perhaps.
The text was updated successfully, but these errors were encountered: