-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare-release command does nothing #883
Comments
So it turns out having uncommited changes at all in the repo is a nogo. I was tricked having no errors displayed, and by the options to install NBGV in the current folder, which in my environment turned out to be the root of my git directory. The tip was actually error code 13 (which for some reason I didn't check before), looking at the source code, we have then an explanation. How would you feel about having some error logging in the console ? I think it's something I can contribute. |
I see in the
Are you looking for something more noticeable? Or is the problem that that didn't look like a fatal error when it in fact was? |
Well it's exactly what you said.
First, we should an have explicit message in case of a fatal error, for all of them
Second, more related to this specific Uncommitted Changes error:
* It just states that there are uncommitted changes, but does not tell the user it's a problem.
* It list files not related to the problem, adding to the confusion. In my case some of them were buried deep in the output.
Third, I feel this requirement should be mentioned somewhere (apologies if I missed it)
So for what I propose it's :
1. Ensure we don't exit with error without an error message.
2. For this specific error, list only the files that cause the problem, and make it clear there should not be uncommitted changes
3. Adapt a Readme with this info. Maybe also the CI part of the NBGV utility : in my case, replicacting my CI environment and executing the documented command caused me to install the tool at the root of the git repo, creating the issue.
|
Sounds good to me. |
I think I'm done with the PR. So my initial idea of requiring to throw with an error message in case of an error, then formatting it as an error in a central part of |
UPDATE: I found out, it was because of uncommited changes in the repo. See my reply below
Hello,
I must be doing something wrong, or maybe I missed something in the docs.
But still, I can't use NBGV because
nbgv.exe prepare-release
doesn't do anything.I've followed the Using the nbgv .NET Core CLI tool guide. Appreciate all the help I can get.
I'm trying to use the tool in an existing repo. So, command by command, here it is:
Now the interesting part:
As you can see:
version.json
is not modifiedEven if I add a
release
configuration:Then I do another
nbgv prepare-release
, it's the same result... I've also tried other options, such asnbgv prepare-release TAG
,nbgv prepare-release --versionIncrement minor
... with no success.What am I doing wrong ?
Thanks !
The text was updated successfully, but these errors were encountered: