-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ProjectReference into a conditional import #1043
Conversation
This makes the `ProjectReference` item itself completely undiscoverable for project systems that enumerate references using the MSBuild API that gets items regardless of condition, which appears to be how the legacy project system (csproj.dll) does it at least sometimes. Fixes #1040
@thomas-ravkilde Can you test this? You can download the nupkg from the PR build artifacts. Let me know if you need more instructions. |
@AArnott Sorry for the delay. I'm afraid I need some more instructions. I thought I could just include prereleases in the VS NuGet Package Manager but that doesn't appear to be the case. I see v3.6.79-alpha as the latest prerelease on v3.6. Where do I find the PR build artifacts? |
Perfectly understandable, and thank you for trying. The instructions for consuming PR build artifacts is near the bottom of our README. |
Ah, I see. Thanks, I couldn't figure out how to get to the PR build artifacts. |
Thanks for testing and reporting back. |
Hm... Very interesting.
So it appears that your change did actually fix the issue but that there was something sticky in the build process. |
Progress. Great. Can you verify with one more step: roll back to the latest release of NB.GV and verify that even after |
@thomas-ravkilde I'm holding off merging this awaiting your confirmation on my last request. |
@AArnott OK. I finally got around to testing this thoroughly.
So I guess you shouldn't merge. I'm sorry to have wasted your time. |
Great. I'm glad to hear the original fix for this was adequate. I don't know why |
This makes the
ProjectReference
item itself completely undiscoverable for project systems that enumerate references using the MSBuild API that gets items regardless of condition, which appears to be how the legacy project system (csproj.dll) does it at least sometimes.Fixes #1040