Fix suboptimal incremental build due to faulty CompareFiles task #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
commented
Sep 25, 2022
src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets
Outdated
Show resolved
Hide resolved
It's a cheap fix, in that it gives up streaming during the compare, but it's far more likely to be accurate than if I tried to maintain streaming while fixing the original bug of assuming that `Stream.Read` will always fill the buffer. Fixes #825
AArnott
changed the title
This was referenced Oct 24, 2022
This was referenced Mar 28, 2023
This was referenced Mar 28, 2023
brighid-bot
added a commit
to cythral/brighid-commands
that referenced
this pull request
Mar 29, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Nerdbank.GitVersioning](https://togithub.com/dotnet/Nerdbank.GitVersioning) | nuget | patch | `3.5.113` -> `3.5.119` | --- ### Release Notes <details> <summary>dotnet/Nerdbank.GitVersioning</summary> ### [`v3.5.119`](https://togithub.com/dotnet/Nerdbank.GitVersioning/releases/v3.5.119) #### What's Changed - Add GetTargetPath target for SqlServer projects by [@​AArnott](https://togithub.com/AArnott) in dotnet/Nerdbank.GitVersioning#821 - Fix suboptimal incremental build due to faulty CompareFiles task by [@​AArnott](https://togithub.com/AArnott) in dotnet/Nerdbank.GitVersioning#826 - Update NuGet.PackageManagement to 6.3.1 by [@​AArnott](https://togithub.com/AArnott) in dotnet/Nerdbank.GitVersioning#851 **Full Changelog**: dotnet/Nerdbank.GitVersioning@v3.5.113...v3.5.119 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task was faulty because it assumed
Stream.Readwould fill the buffer if at all possible.Fixes #825