Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove BOM from version.schema.json #841

Merged
merged 1 commit into from Oct 14, 2022

Conversation

amis92
Copy link
Contributor

@amis92 amis92 commented Oct 14, 2022

Fixes #839

Visual Studio Code complains that the version.schema.json file contains a BOM, when referencing https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/main/src/NerdBank.GitVersioning/version.schema.json as $schema.

This PR removes BOM from the version.schema.json. It shouldn't negatively impact any tooling.

@AArnott AArnott merged commit caa9543 into dotnet:main Oct 14, 2022
@amis92 amis92 deleted the fix/remove-version.schema.json-bom branch October 14, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version.schema.json is UTF-8 with BOM, VSCode expects no BOM
2 participants