Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagName option to customize generated tag name #875

Merged
merged 4 commits into from
Jan 28, 2023

Conversation

ronaldbarendse
Copy link
Contributor

@ronaldbarendse ronaldbarendse commented Dec 15, 2022

This fixes #874 by adding a new option to the version.json file to allow customizing the generated tag name, defaulting to:

{
  "release": {
    "tagName": "v{version}"
  }
}

This default value is the same as was hardcoded before (see linked issue). resulting in the same output:

❯ nbgv tag
v11.0.0-alpha tag created at e9733c696af583dc2d1e988ce9b9dbbdada70596.
Remember to push to a remote: git push origin v11.0.0-alpha

Changing this option to e.g. release-{version} will result in the following output:

❯ nbgv tag
release-11.0.0-alpha tag created at fdb649066fb8a855660844c345b9a905034ca6b6.
Remember to push to a remote: git push origin release-11.0.0-alpha

@dnfadmin
Copy link

dnfadmin commented Dec 15, 2022

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. I'm willing to merge, but can you address the few minor issues I call out?

src/NerdBank.GitVersioning/version.schema.json Outdated Show resolved Hide resolved
src/NerdBank.GitVersioning/VersionOptions.cs Outdated Show resolved Hide resolved
src/NerdBank.GitVersioning/version.schema.json Outdated Show resolved Hide resolved
@ronaldbarendse
Copy link
Contributor Author

Thanks for putting this together. I'm willing to merge, but can you address the few minor issues I call out?

No problem at all, thanks for creating and maintaining this tool! I've addressed all the things you pointed out, so should be good to merge if everything tests out correctly 😄

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.

@AArnott AArnott merged commit 7d22ed6 into dotnet:main Jan 28, 2023
@ronaldbarendse ronaldbarendse deleted the feature/tagname branch September 17, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow customizing generated tag name
3 participants