Allow version.txt files to live in a subdirectory and have the major.minor picked up during the build #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minor picked up during the build
AArnott
added a commit
that referenced
this pull request
Sep 24, 2015
Allow version.txt files to live in a subdirectory and have the major.minor picked up during the build
AArnott
added a commit
that referenced
this pull request
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if the version.txt file did not live at the repo root, it's contents would not be located in any historical git commit during the build, which would cause all version numbers to stat with 0.0.x. I added a regression test for the scenario, and some extra test coverage for the subdirectory case, in addition to some minor fixes/cleanup along the way.